Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349943: [JMH] Use jvmArgs consistently #83

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 20, 2025

Hi all,

This pull request contains a backport of commit 3ebed783 from the openjdk/jdk repository.

The commit being backported was authored by Nicole Xu on 20 Feb 2025 and was reviewed by SendaoYan, Claes Redestad and Hao Sun.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349943 needs maintainer approval

Issue

  • JDK-8349943: [JMH] Use jvmArgs consistently (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.org/jdk24u.git pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/83.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349943: [JMH] Use jvmArgs consistently

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 2d22e13: 8349150: Support precompiled headers on AIX
  • f8b84a9: 8347377: Add validation checks for ICC_Profile header fields
  • ab9a2fd: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
  • 924e7bb: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
  • 05d5371: 8349039: Adjust exception No type named in database
  • a5f39c1: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
  • e06d01d: 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3ebed78328bd64d2e18369d63d6ea323b87a7b24 8349943: [JMH] Use jvmArgs consistently Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix JMH test bugs which cause some JMH test fails. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@sendaoYan
8349943: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Feb 25, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2025

Going to push as commit bbecbaf.
Since your change was applied there have been 8 commits pushed to the master branch:

  • a0bee88: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V
  • 2d22e13: 8349150: Support precompiled headers on AIX
  • f8b84a9: 8347377: Add validation checks for ICC_Profile header fields
  • ab9a2fd: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
  • 924e7bb: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
  • 05d5371: 8349039: Adjust exception No type named in database
  • a5f39c1: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
  • e06d01d: 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2025
@openjdk openjdk bot closed this Feb 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2025
@openjdk
Copy link

openjdk bot commented Feb 26, 2025

@sendaoYan Pushed as commit bbecbaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant